Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick otbr commits #170

Merged
merged 7 commits into from
Dec 8, 2021
Merged

Cherry pick otbr commits #170

merged 7 commits into from
Dec 8, 2021

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Dec 7, 2021

This pull request is intended to update the canary with the latest otbr commits, so that we can continue the compatibility pr of both repositories. This pull must be merged without squash so that the original authors' commits are preserved.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

gpedro and others added 3 commits December 7, 2021 19:56
Remove healing spells overhead by not calculatig critical damage (looking for monsterstypes and getting bestiary charm).
@dudantas dudantas force-pushed the cherry-pick-otbr-commits branch 2 times, most recently from 2de5149 to d968523 Compare December 7, 2021 23:12
@dudantas dudantas mentioned this pull request Dec 8, 2021
8 tasks
gg-martins091 and others added 2 commits December 8, 2021 17:15
Changed so that compilation with debug information is by default, thus facilitating visual studio debugger log.
dudantas and others added 2 commits December 8, 2021 18:48
…optimized forgottenserver

NOTE: This commit request is necessary for the pull of imbuement rework and convert to c++: #164. If don't use this commit, the imbuement will crash!

ItemAttributes otimization, cherry-pick of saiyansking optimized forgottenserver, very thanks.
Co-authored by: @SaiyansKing.
Client support 12.72.11206, download link: https://github.com/dudantas/tibia-client/tree/12.72.11206

Thanks to Rick (@FakeShinoda) for the help on market bytes.
Thanks to @hyresu for help with fix hireling offer

Added:
• Cyclopedia Character Stats - Bytes for cleave damage, reflect damage, perfect shot, magic shield capacity, concoctions potions
• Market -Bytes for cleave damage, reflect damage, perfect shot, magic shield capacity
• Missing creature icons

• Only protocol bytes
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
1.0% 1.0% Duplication

@dudantas dudantas merged commit 77e037d into master Dec 8, 2021
@dudantas dudantas deleted the cherry-pick-otbr-commits branch December 8, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants