improve: targetList / friendList #1739
reviewdog [luacheck] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (79)
data/chatchannels/scripts/guild_leaders.lua|5 col 26| value of argument 'type' is overwritten on line 9 before use
data/events/scripts/creature.lua|7 col 8| value assigned to variable 'time' is unused
data/events/scripts/monster.lua|1 col 16| unused function 'calculateBonus'
data/events/scripts/monster.lua|12 col 16| unused function 'checkItemType'
data/events/scripts/player.lua|400 col 33| value of argument 'name' is overwritten on line 401 before use
data/events/scripts/player.lua|609 col 3| value assigned to variable 'item' is unused
data/libs/daily_reward/daily_reward.lua|41 col 8| value assigned to variable 'maxsoul' is unused
data/libs/daily_reward/daily_reward.lua|81 col 9| unused variable 'a'
data/libs/encounters_lib.lua|93 col 34| shadowing upvalue argument 'callable' on line 91
data/libs/encounters_lib.lua|174 col 27| shadowing upvalue loop variable 'position' on line 172
data/libs/encounters_lib.lua|178 col 32| shadowing upvalue loop variable 'position' on line 172
data/libs/encounters_lib.lua|190 col 12| shadowing definition of argument 'event' on line 178
data/libs/encounters_lib.lua|196 col 12| shadowing upvalue 'monster' on line 179
data/libs/functions/bosslever.lua|217 col 41| shadowing upvalue 'zone' on line 162
data/libs/functions/combat.lua|3 col 24| shadowing upvalue argument 'creature' on line 1
data/libs/functions/combat.lua|14 col 28| shadowing upvalue argument 'creature' on line 12
data/libs/functions/functions.lua|248 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|263 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|444 col 10| unused variable 'tile'
data/libs/functions/functions.lua|468 col 38| shadowing upvalue argument 'message' on line 423
data/libs/functions/functions.lua|632 col 11| shadowing definition of variable 'player' on line 578
data/libs/functions/functions.lua|673 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|785 col 8| variable 'buffer' was previously defined as an argument on line 784
data/libs/functions/functions.lua|823 col 8| variable 'i' was previously defined as an argument on line 822
data/libs/functions/game.lua|51 col 16| value assigned to variable 'house' is unused
data/libs/functions/game.lua|63 col 17| value assigned to variable 'player' is unused
data/libs/functions/game.lua|79 col 17| value assigned to variable 'player' is unused
data/libs/functions/monstertype.lua|36 col 9| value assigned to variable 'count' is unused
data/libs/functions/player.lua|540 col 2| loop is executed at most once
data/libs/functions/position.lua|139 col 8| unused variable 'spectators'
data/libs/functions/position.lua|140 col 8| variable 'spectators' was previously defined on line 139
data/libs/functions/position.lua|140 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/position.lua|150 col 8| value assigned to variable 'result' is overwritten on line 153 before use
data/libs/functions/position.lua|166 col 8| value assigned to variable 'result' is overwritten on line 169 before use
data/libs/functions/string.lua|55 col 9| unused variable 'a'
data/libs/functions/tables.lua|43 col 8| unused variable 'newthing'
data/libs/hireling_lib.lua|618 col 9| shadowing definition of variable 'outfit' on line 594
data/modules/lib/modules.lua|7 col 20| shadowing upvalue argument 'callable' on line 1
data/modules/lib/modules.lua|7 col 30| shadowing upvalue argument 'playerId' on line 1
data/modules/lib/modules.lua|8 col 9| shadowing upvalue 'player' on line 2
data/modules/scripts/blessings/blessings.lua|249 col 16| unused variable 'bless'
data/modules/scripts/daily_reward/daily_reward.lua|38 col 7| unused variable 'DAILY_REWARD_NONE'
data/modules/scripts/daily_reward/daily_reward.lua|39 col 7| unused variable 'DAILY_REWARD_HP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|40 col 7| unused variable 'DAILY_REWARD_MP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|41 col 7| unused variable 'DAILY_REWARD_STAMINA_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|42 col 7| unused variable 'DAILY_REWARD_DOUBLE_HP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|43 col 7| unused variable 'DAILY_REWARD_DOUBLE_MP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|44 col 7| unused variable 'DAILY_REWARD_SOUL_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|59 col 7| unused variable 'DAILY_REWARD_SYSTEM_TYPE_OTHER'
data/modules/scripts/daily_reward/daily_reward.lua|603 col 40| empty if branch
data/modules/scripts/gamestore/init.lua|241 col 51| empty if branch
data/modules/scripts/gamestore/init.lua|339 col 9| value assigned to variable 'category' is unused
data/modules/scripts/gamestore/init.lua|357 col 9| value assigned to variable 'category' is unused
data/modules/scripts/gamestore/init.lua|568 col 8| value assigned to variable 'GameStoreCategories' is unused
data/modules/scripts/gamestore/init.lua|568 col 29| value assigned to variable 'GameStoreCount' is unused
data/modules/scripts/gamestore/init.lua|616 col 8| unused variable 'playerId'
data/modules/scripts/gamestore/init.lua|1403 col 7| shadowing definition of loop variable 'k' on line 1402
data/modules/scripts/gamestore/init.lua|1453 col 7| shadowing definition of loop variable 'k' on line 1452
data/modules/scripts/gamestore/init.lua|1480 col 7| shadowing definition of loop variable 'i' on line 1478
data/modules/scripts/gamestore/init.lua|1727 col 3| value assigned to variable 'message' is unused
data/modules/scripts/gamestore/init.lua|1729 col 10| shadowing upvalue argument 'player' on line 1697
data/modules/scripts/gamestore/init.lua|1976 col 8| value assigned to variable 'op' is unused
data/modules/scripts/gamestore/init.lua|2198 col 22| shadowing upvalue argument 'playerId' on line 2195
data/modules/scripts/gamestore/init.lua|2199 col 9| unused variable 'offer'
data/modules/scripts/gamestore/init.lua|2199 col 9| shadowing upvalue argument 'offer' on line 2195
data/modules/scripts/gamestore/init.lua|2200 col 9| shadowing upvalue argument 'newHirelingName' on line 2195
data/modules/scripts/gamestore/init.lua|2201 col 9| shadowing upvalue 'player' on line 2196
data/modules/scripts/gamestore/init.lua|2231 col 22| shadowing upvalue argument 'playerId' on line 2228
data/modules/scripts/gamestore/init.lua|2232 col 9| shadowing upvalue 'player' on line 2229
data/modules/scripts/hirelings/hireling_module.lua|14 col 8| value assigned to variable 'outfitType' is overwritten on line 15 before use
data/npclib/npc_system/custom_modules.lua|8 col 8| value assigned to variable 'discount' is unused
data/npclib/npc_system/npc_handler.lua|582 col 3| value assigned to variable 'events' is unused
data/scripts/eventcallbacks/monster/on_spawn.lua|56 col 10| shadowing definition of argument 'monster' on line 38
data/scripts/talkactions/gm/position.lua|7 col 8| variable 'param' was previously defined as an argument on line 3
data/scripts/talkactions/gm/teleport_to_player.lua|42 col 54| shadowing upvalue argument 'player' on line 3
data/scripts/talkactions/god/add_addon.lua|32 col 8| shadowing upvalue 'addons' on line 1
data/scripts/talkactions/god/add_outfit.lua|37 col 2| unreachable code
data/scripts/talkactions/god/zones.lua|67 col 11| shadowing upvalue argument 'player' on line 3
data/scripts/talkactions/player/reward.lua|21 col 47| shadowing upvalue argument 'player' on line 13