Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: koshei switch wrong ids combination #1819

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

Leshyah
Copy link
Contributor

@Leshyah Leshyah commented Nov 13, 2023

Description

Koshei switch script has the wrong combination.

Behaviour

Lighting the wrong statues leads to open staircase

Expected

Lighting the north and east statues and then using the sun dial should open the staircase.

Fixes

Corrects the id needed for each position so that the correct lit statues are needed to open staircase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Lit correct statues and used sun dial and opened staircase.

Test Configuration:

  • Server Version: 3.1.1
  • Client: 1321
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Leshyah Leshyah changed the title Koshei switch fix: Koshei switch Nov 13, 2023
@elsongabriel
Copy link
Contributor

PR #1682 didn't fix?

@Leshyah
Copy link
Contributor Author

Leshyah commented Nov 13, 2023

PR #1682 didn't fix?

It has the wrong combination.

@dudantas dudantas changed the title fix: Koshei switch fix: Koshei switch wrong ids combination Nov 13, 2023
@dudantas dudantas changed the title fix: Koshei switch wrong ids combination fix: koshei switch wrong ids combination Nov 13, 2023
@dudantas dudantas merged commit b8bfcaa into opentibiabr:main Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants