Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create familiars lib #182

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Create familiars lib #182

merged 5 commits into from
Jan 10, 2022

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented Jan 8, 2022 •
edited by dudantas
Loading

Co-Authored-By: @dudantas eduardo.dantas@hotmail.com.br

Description

Somes familiars fixes and adjusts

Rename from "pet/Pet" to "familiar/Familiar"
Removed "familiar = false" from monsters, this is false by default
Renamed from "mtype:isPet" to "mtype:familiar"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@beats-dh @dudantas
Create familiars lib
64149e0 
Co-Authored-By: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit ad7a35b into opentibiabr:master Jan 10, 2022
@beats-dh beats-dh deleted the Create-familiars-lib branch January 30, 2022 18:34
luan pushed a commit that referenced this pull request Jul 11, 2023
@beats-dh @dudantas
Create familiars lib (#182)
3474b76 
Somes familiars fixes and adjusts

Rename from "pet/Pet" to "familiar/Familiar"
Removed "familiar = false" from monsters, this is false by default
Renamed from "mtype:isPet" to "mtype:familiar"

Co-authored-by: @dudantas <eduardo.dantas@hotmail.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omeranha omeranha omeranha approved these changes

@mattyx14 mattyx14 mattyx14 approved these changes

Assignees
No one assigned
Labels
Area: Datapack Global Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beats-dh @mattyx14 @omeranha @dudantas