Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust bosses lever and other fixes #1934

Merged

Conversation

elsongabriel
Copy link
Contributor

Description

  • Added default value for config 'timeAfterKill' in BossLever to 60 and removed from bosses;
  • Added missing storage;
  • Improvement in the 'clearBossRoom' function;
  • Adjust loot and config elements from monsters and bosses. Updating exp and hp from Ferumbras.
  • Improved defense and atk from training machine;
  • Changing rewardBoss flag and removing functions from non-bosses;
  • Fixed check on online_coins script;
  • Magma bubble: fixed mechanic. Removing players from the room, when magma was defeated;

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: Canary 3.3.1
  • Client: 13.21
  • Operating System: Windows 11 / Ubuntu 22.04

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luan luan merged commit c578484 into opentibiabr:main Dec 2, 2023
10 checks passed
@elsongabriel elsongabriel deleted the fix/adjust-bosses-lever-and-other-fixes branch December 4, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants