Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Npc Shop Enhancement] - Allow an item of the same id to be added multiple times for the same npc #207

Merged
merged 7 commits into from
Feb 13, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Feb 13, 2022

Description

Set for use name of the item instead of id in the ShopInfoMap vector
This will allow adding items with the same item ids and customizing the item name
Fixed somes npcs shop bugs

This will allow adding items with the same item ids and customizing the item name
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 9c257da into master Feb 13, 2022
@dudantas dudantas deleted the fix-npc-shop branch February 13, 2022 23:46
luan pushed a commit that referenced this pull request Jul 11, 2023
…tiple times for the same npc (#207)

Set for use name of the item instead of id in the ShopInfoMap vector
This will allow adding items with the same item ids and customizing the item name
Fixed somes npcs shop bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants