Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cyclopedia house auction #3022

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: cyclopedia house auction #3022

wants to merge 32 commits into from

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Oct 27, 2024

Description

  • Bid
  • Move out
  • Transfer
  • Error Handling

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Delete testByte.lua
@murilo09 murilo09 changed the title feat: house auction feat: cyclopedia house auction Oct 30, 2024
@murilo09 murilo09 force-pushed the test-house branch 3 times, most recently from 146da72 to 9a2fc29 Compare October 30, 2024 13:22
@murilo09 murilo09 marked this pull request as ready for review October 30, 2024 19:01
@htc16

This comment was marked as resolved.

@htc16

This comment was marked as resolved.

@phacUFPE
Copy link
Contributor

It is not possible to add VIP to the account, when you add and relog the account and character it goes back to 0 days. From my investigation, the lastday column is not saving time. And when I manually add the lastday it works. The premdays_purchased column apparently isn't fed either, I had to feed it manually.

edit: I believe the error is here image

You are right, it is reversed the houseBidId with the accountId. I just reverted.

Copy link

sonarcloud bot commented Nov 19, 2024

@htc16
Copy link
Contributor

htc16 commented Nov 19, 2024

It is not possible to add VIP to the account, when you add and relog the account and character it goes back to 0 days. From my investigation, the lastday column is not saving time. And when I manually add the lastday it works. The premdays_purchased column apparently isn't fed either, I had to feed it manually.
edit: I believe the error is here image

You are right, it is reversed the houseBidId with the accountId. I just reverted.

I forgot to mention that you need to add: #include "account/account.hpp" in the house_functions.cpp file.

Corlyone added a commit to Corlyone/canary3 that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Reviewers/Test
Development

Successfully merging this pull request may close these issues.

4 participants