Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: character cyclopedia item inspection imbuements #3065

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Nov 5, 2024

Description

This fixes the icons from the character item imbuements inspection cyclopedia.

Behaviour

Actual

image

Expected

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Imbue any item
  • Equip the item
  • Go to cyclopedia and check the imbuement icon

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

sonarqubecloud bot commented Nov 6, 2024

@dudantas dudantas merged commit 3bef034 into main Nov 6, 2024
36 checks passed
@dudantas dudantas deleted the phacUFPE/fix_item_inspection_imbuements branch November 6, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants