Prevents the loop of player from pushing another player #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
dudantas
force-pushed
the
fix-push-player-bug
branch
from
577a535
to
425e411
Compare
…op until it manages to pull it or get out of range When player 1 tried to pull player 2, from a distance, player 1's character only stopped when he could pull player 2 or when out of range (assuming that player 1 kept trying to go in the opposite direction of player 2). That way, if player 1 makes a move, the push stops automatically.
dudantas
force-pushed
the
fix-push-player-bug
branch
from
425e411
to
2c03156
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Added enable/disable push when attacking to config.lua (default value is false). Prevents the character from pulling another one, continuing in the loop until it manages to pull it or get out of range. How the bug works: When player 1 tries to pull player 2, from a distance, player 1's character only stopped when he could pull player 2 or when out of range (assuming that player 1 kept trying to go in the opposite direction of player 2). With this changes, if player 1 makes one movement, the push stops automatically.
luan
added a commit
that referenced
this pull request
Jul 23, 2023
luan
added a commit
that referenced
this pull request
Jul 27, 2023
luan
added a commit
that referenced
this pull request
Jul 27, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added enable/disable push when attacking to config.lua (default value is false).
Prevents the character from pulling another one, continuing in the loop until it manages to pull it or get out of range.
How the bug works: When player 1 tries to pull player 2, from a distance, player 1's character only stopped when he could pull
player 2 or when out of range (assuming that player 1 kept trying to go in the opposite direction of player 2). With this changes, if player 1 makes one movement, the push stops automatically.
Type of change
Checklist