Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Changed rsa to use gmp lib instead of cryptopp #391

Merged
merged 18 commits into from
Jun 6, 2022

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented May 24, 2022

Thanks and credits to @SaiyansKing
This pull request has modifications from the optimized forgottenserver: https://github.com/opentibiabr/optimized_forgottenserver

Added function in otserv.cpp to load default RSA key if it fails to load key.pem
Rework on connection.cpp and improvement of some functions
Removed some "reinterpret_cast", added in place "static_cast" which avoid overflows or undefined behavior
Improved connection and protocol code for QT client

@beats-dh beats-dh marked this pull request as draft May 24, 2022 04:10
@dudantas dudantas marked this pull request as ready for review June 3, 2022 18:29
Fix build docker
Fix compilation
Convert from unsigned char to uint8_t
@dudantas dudantas changed the title Remove lib cryptopp++ Changed rsa to use gmp lib instead of cryptopp Jun 6, 2022
@dudantas dudantas changed the title Changed rsa to use gmp lib instead of cryptopp [Enhancement] Changed rsa to use gmp lib instead of cryptopp Jun 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit b0538c4 into opentibiabr:main Jun 6, 2022
@beats-dh beats-dh deleted the rsa branch June 6, 2022 16:15
luan pushed a commit that referenced this pull request Jul 11, 2023
Thanks and credits to @SaiyansKing
This pull request has modifications from the optimized forgottenserver: https://github.com/opentibiabr/optimized_forgottenserver

Added function in otserv.cpp to load default RSA key if it fails to load key.pem
Rework on connection.cpp and improvement of some functions
Removed some "reinterpret_cast", added in place "static_cast" which avoid overflows or undefined behavior
Improved connection and protocol code for QT client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants