Fixed potion mana amount heals, remove wrong parameter from doTargetCombatMana on potions.lua

[Brunoquindeler]

Description

was being passed an extra parameter in the "doTargetCombatMana" function, this function randomizes the amount of mana a potion heals. With this parameter, the minimum "6" was always passed, which is the value of the constant "COMBAT_MANADRAIN", thus making an "ultimate mana potion", for example, heal 80, 100, 130... however, it should cure between 425 and 575.

here the function that is called and where the parameter is used

canary/src/lua/functions/core/game/global_functions.cpp

Line 391 in 0e43691

int GlobalFunctions::luaDoTargetCombatMana(lua_State* L) {

See on Line 413. The minimum and maximum parameters are in order 3 and 4.

canary/src/lua/functions/core/game/global_functions.cpp

Line 413 in 0e43691

damage.primary.value = normal_random(getNumber<int32_t>(L, 3), getNumber<int32_t>(L, 4));

and the effect type is already applied on line 412.

canary/src/lua/functions/core/game/global_functions.cpp

Line 412 in 0e43691

damage.primary.type = COMBAT_MANADRAIN;

Behaviour

Actual

an "ultimate mana potion", for example, heal 80, 100, 130...

Expected

an "ultimate mana potion", for example, heal between 425 - 575

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested

Tests were done in-game

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[dudantas]

Merged, thanks for your contribution!