-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rope fix #6
Merged
Merged
Rope fix #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Aug 24, 2021
dudantas
approved these changes
Aug 24, 2021
2 tasks
5 tasks
10 tasks
1 task
5 tasks
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Simplify cmake includes to use absolute path within directory hierarchy (#6)
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Provide correct item ids for rope spots * Remove unused RopeSpots table
5 tasks
5 tasks
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the rope spots that had mismatched item ids and removes an unused table in actions.lua.
Behaviour
Actual
Rope spot item ids were wrong
Expected
For them to be correct.
Fixes
Changed item ids of ropeSpots table and removed RopeSpots from actions.lua
# (issue)
Type of change
How Has This Been Tested
Tried to use each rope spot and was successfully able to rope up.
Test Configuration:
Checklist