Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rope fix #6

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Rope fix #6

merged 4 commits into from
Aug 24, 2021

Conversation

hiPirate
Copy link
Contributor

Description

This fixes the rope spots that had mismatched item ids and removes an unused table in actions.lua.

Behaviour

Actual

Rope spot item ids were wrong

Expected

For them to be correct.

Fixes

Changed item ids of ropeSpots table and removed RopeSpots from actions.lua

# (issue)

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Tried to use each rope spot and was successfully able to rope up.

Test Configuration:

  • Server Version: master
  • Client: 12.64? 11.00? 10.00? idk
  • Operating System: Windows 11 x64

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dudantas dudantas merged commit a30eaf1 into opentibiabr:master Aug 24, 2021
@helenarubra helenarubra mentioned this pull request Oct 12, 2021
1 task
@Methemia Methemia mentioned this pull request Oct 15, 2021
4 tasks
@Zapotoczny Zapotoczny mentioned this pull request Oct 15, 2022
5 tasks
@QuebradaZN QuebradaZN mentioned this pull request Dec 27, 2022
10 tasks
luan pushed a commit that referenced this pull request Jul 11, 2023
Simplify cmake includes to use absolute path within directory hierarchy (#6)
luan pushed a commit that referenced this pull request Jul 11, 2023
* Provide correct item ids for rope spots

* Remove unused RopeSpots table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants