fix: handling nullptr in Game::internalMoveItem and other functions #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
approved these changes
Jan 4, 2023
carlospess0a
approved these changes
Jan 4, 2023
murilo09
approved these changes
Jan 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
added a commit
to dudantas/canary
that referenced
this pull request
Feb 7, 2023
…opentibiabr#737) Added nullptr handling to the fromCylinder and toCylinder parameters in the Game::internalMoveItem function and others functions. This prevents crashes due to invalid memory access when these parameters are nullptr. Additionally, an error log has been added to make it easier to track potential issues.
jacksonie
pushed a commit
to jacksonie/canary
that referenced
this pull request
Feb 17, 2023
…opentibiabr#737) Added nullptr handling to the fromCylinder and toCylinder parameters in the Game::internalMoveItem function and others functions. This prevents crashes due to invalid memory access when these parameters are nullptr. Additionally, an error log has been added to make it easier to track potential issues.
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
…#737) Added nullptr handling to the fromCylinder and toCylinder parameters in the Game::internalMoveItem function and others functions. This prevents crashes due to invalid memory access when these parameters are nullptr. Additionally, an error log has been added to make it easier to track potential issues.
dudantas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds nullptr handling to the fromCylinder and toCylinder parameters in the Game::internalMoveItem function and others functions. This prevents crashes due to invalid memory access when these parameters are nullptr. Additionally, an error log has been added to make it easier to track potential issues.
Type of change