Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple npcs from the creature class (it's create npc.xml file in the world folder) #3

Merged
merged 16 commits into from
May 25, 2021

Conversation

dudantas
Copy link

@dudantas dudantas commented Mar 28, 2021

Created the complete organization of npcs, that way, it is possible to create own files for npcs, no longer depending on being together with the monsters
this pull request was made to be worked together with the canary project: https://github.com/opentibiabr/canary

The spawns npcs is "yellow" and spawns monsters is "red" (the old)

With this change, the map will automatically create an "npc.xml" the first time it is saved.
It is possible to edit only the xml, it is not necessary to add or modify the npc by opening the editor map

Thus, there is a script for npcs, similar to how it works with old spawns

image
image
image
image
image
image

It is likely that something remains to be adapted, I will still look at it calmly, but it is functional, any help for testing is welcome.

With this change, the map will automatically create an "npc.xml" the first time it is saved.
It is possible to edit only the xml, it is not necessary to add or modify the npc by opening the editor map
created the complete organization of npcs, that way, it is possible to create own files for npcs, no longer depending on being together with the monsters
this pull request was made to be worked together with the otservbr-global pull: https://github.com/opentibiabr/otservbr-global/pull/2499

thus, there is a script for npcs, similar to how it works with old spawns
@dudantas dudantas changed the title Save an "npc.xml" file to the world folder Decouple npcs from the creature class (it's create npc.xml file in the world folder) Mar 31, 2021
source/common_windows.h Outdated Show resolved Hide resolved
source/copybuffer.cpp Outdated Show resolved Hide resolved
source/creature_brush.cpp Show resolved Hide resolved
source/editor.cpp Outdated Show resolved Hide resolved
source/editor.cpp Outdated Show resolved Hide resolved
source/iomap_otbm.cpp Outdated Show resolved Hide resolved
source/map_display.cpp Outdated Show resolved Hide resolved
source/old_properties_window.cpp Outdated Show resolved Hide resolved
source/palette_house.cpp Outdated Show resolved Hide resolved
source/tile.h Outdated Show resolved Hide resolved
Fix for use assets for client version 11+
Fix for show "Npc Palette" in the "view" window
Fix warning of flags
This meant that when dragging the spawn from the npc, it took the npc along (when both were in the same sqm)
Fixed npcs name from snack case to title case
@dudantas dudantas merged commit e09f3e9 into opentibiabr:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants