Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set toolbar-tip tipHoverable to false #195

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

kagol
Copy link
Member

@kagol kagol commented Jan 5, 2025

PR

之前鼠标移到提示上时,提示未隐藏,这样会导致一个问题:

  • 当提示工具栏折行时,鼠标移到下面一行的工具栏图标A上,这时出现提示,我想再移到A上方的工具栏图标B上面,直接鼠标往上移动是不行的,因为会移到提示上面,而提示遮挡住了工具栏图标B。
  • 需要先要移到别处,让提示消失,然后小心翼翼地移到图标B上。

优化后,不管鼠标怎么移动,都能看到提示。

优化前效果:
toolbat-tip效果

优化后效果:
toolbat-tip效果-优化后

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Chores

    • Updated package names from "fluent-editor-docs" to "docs" across project configuration files
    • Updated quill-toolbar-tip package version to ^0.0.7
  • Configuration

    • Modified toolbar tooltip configuration to disable hover behavior in FluentEditor

@kagol kagol added the documentation Improvements or additions to documentation label Jan 5, 2025
Copy link

coderabbitai bot commented Jan 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves renaming packages from "fluent-editor-docs" to "docs" across multiple configuration files and updating the toolbar tip configuration in a Vue component. The changes primarily focus on package naming consistency and modifying the tooltip behavior by setting tipHoverable to false. The quill-toolbar-tip package version was also incrementally updated from 0.0.6 to 0.0.7.

Changes

File Change Summary
package.json Updated script commands from fluent-editor-docs to docs for dev, build, install:browser, test, and report
packages/docs/fluent-editor/demos/toolbar-tip.vue Modified toolbar-tip configuration from true to an object with defaultTooltipOptions: { tipHoverable: false }
packages/docs/package.json Renamed package from "fluent-editor-docs" to "docs", updated quill-toolbar-tip package version to ^0.0.7

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • kagol

Poem

🐰 A rabbit's tale of docs and tips,

Renaming packages with gentle flips,

Tooltips dance with hoverable grace,

Code evolves at a playful pace!

Hop, hop, hooray for clean design! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6a2149 and 134c7aa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json (1 hunks)
  • packages/docs/fluent-editor/demos/toolbar-tip.vue (1 hunks)
  • packages/docs/package.json (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

此PR通过将toolbar-tiptipHoverable属性设置为false,优化了工具栏提示的行为,避免了提示遮挡其他图标的问题。此更改确保了在鼠标移动时,提示不会阻挡其他工具栏图标。

Changes

文件 摘要
package.json 更新了脚本命令,替换了fluent-editor-docsdocs
packages/docs/fluent-editor/demos/toolbar-tip.vue 修改了toolbar-tip的配置,将tipHoverable设置为false
pnpm-lock.yaml 更新了quill-toolbar-tip的版本,从0.0.6升级到0.0.7

@kagol kagol merged commit 65ed0fe into main Jan 5, 2025
5 checks passed
@kagol kagol deleted the kagol/toolbar-tip-tipHoverable-false branch January 17, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant