feat(badge): [badge] Adapting to the SMB theme

[Youyou-smiles]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced visual representation of the tiny-badge component with adjusted offset values and new demo badges showcasing various values.
  • Introduced scoped styles for improved layout and appearance of demo badges.

• Bug Fixes

  • Updated expected CSS transformation values in tests to reflect new badge positioning.

• Refactor

  • Changed default offset value representation from strings to numbers for better consistency in component behavior.

• Style

  • Added scoped styles for .demo-badge-offset and .demo-box to enhance the visual layout of badges.

[coderabbitai]

Walkthrough

The pull request introduces several modifications to the tiny-badge component across multiple files. Key changes include adjustments to the offset properties of existing badges, the addition of new demo badges with various values, and updates to the styling of these components. The default offset value in the badge properties has been changed from a string representation to a numeric array, affecting how offsets are handled in the component.

Changes

File Path	Change Summary
examples/sites/demos/pc/app/badge/offset-composition-api.vue, examples/sites/demos/pc/app/badge/offset.vue	Adjusted offset values for existing tiny-badge instances and added new demo badges with consistent offsets. Scoped styles for demo badges and their container were also introduced.
examples/sites/demos/pc/app/badge/offset.spec.ts	Updated expected CSS transformation values for badge elements to reflect new vertical positioning.
packages/theme/src/badge/smb-theme.js	Modified the calculation for the 'ti-badge-line-height' property to improve vertical spacing based on a new line height variable.
packages/vue/src/badge/src/index.ts	Changed the default value of the offset property in badgeProps from an array of strings to an array of numbers.

Possibly related PRs

• feat(badge): [badge] Adapting to the SMB theme #2087: Involves modifications to the tiny-badge component, directly related to the offset adjustments and visual representation in this PR.

Poem

🐇 In the meadow where badges shine,
Offsets dance in a perfect line.
New demos bloom, colors bright,
Styling changes, a joyful sight!
Hopping through code, we celebrate,
Tiny badges, oh, how great! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d30996d and f24d7e3.

Files selected for processing (5)

• examples/sites/demos/pc/app/badge/offset-composition-api.vue (1 hunks)
• examples/sites/demos/pc/app/badge/offset.spec.ts (1 hunks)
• examples/sites/demos/pc/app/badge/offset.vue (2 hunks)
• packages/theme/src/badge/smb-theme.js (1 hunks)
• packages/vue/src/badge/src/index.ts (1 hunks)

Additional comments not posted (13)

examples/sites/demos/pc/app/badge/offset.spec.ts (2)

10-10: LGTM!

The change to the expected CSS transformation value for the first badge is approved. It reflects the new vertical positioning of the badge.

---

11-11: LGTM!

The change to the expected CSS transformation value for the second badge is approved. It reflects the new vertical positioning of the badge.

packages/theme/src/badge/smb-theme.js (1)

3-3: Verify the impact on badge appearance.

The change to the ti-badge-line-height property affects the line height of badges, potentially altering their vertical spacing and overall appearance in the user interface.

Please ensure that this change has been thoroughly tested and validated to confirm that it achieves the desired visual outcome for the badges in the SMB theme.

examples/sites/demos/pc/app/badge/offset-composition-api.vue (4)

5-5: LGTM!

The change to the offset property for the first tiny-badge instance is approved. It increases the vertical offset, positioning the badge lower on the page.

---

9-9: LGTM!

The change to the offset property for the second tiny-badge instance is approved. It modifies the vertical offset, positioning the badge slightly lower on the page.

---

10-20: LGTM!

The addition of the demo badges within the demo-box div is approved. It enhances the visual representation of the badge component by showcasing various badge values with a consistent offset.

---

27-41: LGTM!

The addition of the scoped style section is approved. It defines styles for the demo badges and their container, ensuring a consistent and visually appealing presentation.

examples/sites/demos/pc/app/badge/offset.vue (5)

5-5: LGTM!

The change to the offset property is approved.

---

9-9: LGTM!

The change to the offset property is approved.

---

11-20: LGTM!

The addition of the new section and the new examples of the badge component usage are approved.

---

34-40: LGTM!

The addition of the scoped style section and the styles for .demo-badge-offset are approved.

---

41-46: LGTM!

The addition of the scoped style section and the styles for .demo-box are approved.

packages/vue/src/badge/src/index.ts (1)

50-50: Verify the impact of the change in the default offset value.

The default value of the offset property has been changed from a string representation () => ['0', '-50%'] to a numeric array () => [0, 0].

This change may affect how the offset is interpreted and utilized within the component, potentially leading to changes in rendering behavior or layout calculations that rely on this property.

Run the following script to verify the impact of the change:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[zzcr]

这里默认值怎么又给改了呢