fix(button): add ghost's cssvars for button #2235
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,10 @@ | |
| border-image: initial; | ||
| border-radius: var(--ti-float-button-border-radius); | ||
| background: var(--ti-float-button-normal-background-color); | ||
| box-shadow: | ||
| 0 6px 16px 0 rgba(0, 0, 0, 0.08), | ||
| 0 3px 6px -4px rgba(0, 0, 0, 0.12), | ||
| 0 9px 28px 8px rgba(0, 0, 0, 0.05); | ||
| transition: | ||
| border 0.3s ease 0s, | ||
| color 0.3s ease 0s, | ||
|
|
@@ -54,7 +57,7 @@ | |
| vertical-align: text-top; | ||
| } | ||
|
|
||
| & > img { | ||
| margin-right: 4px; | ||
| vertical-align: middle; | ||
| } | ||
|
|
@@ -129,7 +132,7 @@ | |
| var(--ti-float-button-normal-disabled-bg-color)); | ||
| } | ||
|
|
||
| & + & { | ||
| margin-left: 8px; | ||
| } | ||
|
|
||
|
|
@@ -159,12 +162,9 @@ | |
| .@{svg-prefix-cls} { | ||
| fill: var(--ti-float-button-normal-text-color); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| &.is-icon { | ||
| display: inline-flex; | ||
| justify-content: center; | ||
|
|
@@ -457,7 +457,7 @@ | |
| var(--ti-float-button-size-large-min-width), | ||
| ); | ||
|
|
||
| & + & { | ||
| margin-left: var(--ti-float-button-size-large-margin-left); | ||
| } | ||
| } | ||
|
|
@@ -469,7 +469,7 @@ | |
| var(--ti-float-button-size-medium-min-width), | ||
| ); | ||
|
|
||
| & + & { | ||
| margin-left: var(--ti-float-button-size-medium-margin-left); | ||
| } | ||
| } | ||
|
|
@@ -481,7 +481,7 @@ | |
| var(--ti-float-button-size-small-min-width), | ||
| ); | ||
|
|
||
| & + & { | ||
| margin-left: var(--ti-float-button-size-small-margin-left); | ||
| } | ||
| } | ||
|
|
@@ -494,19 +494,3 @@ | |
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor to Reduce Selector Specificity
The selector
&.is-ghost.is-ghost.is-ghost.is-ghost.is-ghost.is-ghostuses six repetitions of.is-ghostto increase specificity. This approach can reduce maintainability and readability of the code.Consider refactoring to reduce the specificity without relying on repeated class names. One option is to restructure the CSS to avoid the need for such high specificity or to use more specific parent selectors if applicable.
For example, you could adjust the CSS hierarchy or use a more specific attribute selector:
Or, if appropriate, introduce a modifier class that explicitly indicates the higher specificity:
And apply this class where needed in the HTML:
This approach improves code maintainability by avoiding excessive class chaining.