Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cascader): [ cascader] fix active-node 's color and font-weight #2361

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Oct 23, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

修复高亮节点的颜色和字重

Summary by CodeRabbit

  • New Features
    • Enhanced visual styling for the Cascader Node component with updated hover text color and bold font weight for active items.

Copy link

coderabbitai bot commented Oct 23, 2024

Walkthrough

The changes involve updates to CSS variables within the .inject-CascaderNode-vars() function in the vars.less file. Two specific variables have been modified: the text color for selectable items has been changed to a new active color, and the font weight for highlighted items has been altered from regular to bold. These modifications impact the visual styling of the Cascader Node component, particularly in hover states and active item presentation.

Changes

File Path Change Summary
packages/theme/src/cascader-node/vars.less Updated --tv-CascaderNode-selectable-text-color and --tv-CascaderNode-active-font-weight variables.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

🐰 In the garden where colors play,
Cascader nodes dance in a bold array.
Text shines bright, a lovely hue,
With every hover, a fresh debut.
Font weight strong, like a rabbit's cheer,
Styling changes bring us near! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 317064f and 7fb103a.

📒 Files selected for processing (1)
  • packages/theme/src/cascader-node/vars.less (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
packages/theme/src/cascader-node/vars.less (2)

23-23: LGTM! Improved visual feedback for interactive states.

The change from neutral text color to active blue color enhances the visual feedback for selectable items, making the interactive states more apparent to users.


51-51: LGTM! Enhanced visual hierarchy.

Changing the font weight from regular (400) to semi-bold (600) for active nodes improves the visual hierarchy and makes the selected state more prominent while maintaining readability.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2024
@kagol kagol merged commit 124e50a into opentiny:dev Oct 23, 2024
7 checks passed
@shenjunjian shenjunjian deleted the fix-cascader-active-color branch November 7, 2024 02:00
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants