test(e2e): fix action-menu error e2e test

[zzcr]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Tests
  • Updated the test case for the action menu to focus on the visibility of a specific SVG element instead of validating the SVG path.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to a Playwright test case located in the card-mode.spec.ts file. The update replaces a regular expression check for the SVG path attribute with a visibility check for a specific SVG element within the action menu. This change reflects a focus on ensuring that the UI component is visible rather than validating the SVG path data.

Changes

File Path	Change Summary
examples/sites/demos/pc/app/action-menu/card-mode.spec.ts	Removed regex check for SVG path; added visibility check for .tiny-dropdown__suffix-inner .tiny-svg element.

Possibly related PRs

• refactor(action-menu): [action-menu] modify variable names and add refactor styles #2224: This PR modifies the action menu component, which is related to the changes in the main PR that also involves the action menu's test cases.
• test(site): fix icon not correct test e2e #2445: This PR updates the test case for the action menu, specifically focusing on the visibility of an SVG icon, which aligns with the changes made in the main PR regarding the visibility check for a specific SVG element.
• style(action-menu): misspelled word #2431: This PR corrects a misspelled class name related to visibility in the action menu, which is relevant to the main PR's focus on visibility checks in the action menu tests.
• refactor(dropdown/action-menu): [dropdown,action-menu] refactor styles for drodpwn #2343: This PR refactors styles for the action menu, which may indirectly relate to the changes in the main PR that involve testing the visibility of UI components within the action menu.

Suggested labels

bug, e2e-test

Suggested reviewers

• gimmyhehe

🐇 In the meadow where rabbits play,
A test was changed, hip-hip-hooray!
From paths of SVG, we now can see,
A tiny icon, as bright as can be!
Hopping through code, with joy we cheer,
For visibility checks are finally here! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

examples/sites/demos/pc/app/action-menu/card-mode.spec.ts (1)

14-14: Consider improving selector readability

The selector has double spaces between suffix-inner and .tiny-svg which should be normalized.

-  await expect(moreItem.locator('.tiny-dropdown__suffix-inner  .tiny-svg')).toBeVisible()
+  await expect(moreItem.locator('.tiny-dropdown__suffix-inner .tiny-svg')).toBeVisible()

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between da4f7fa and bcd082f.

📒 Files selected for processing (1)

• examples/sites/demos/pc/app/action-menu/card-mode.spec.ts (1 hunks)

🔇 Additional comments (1)

examples/sites/demos/pc/app/action-menu/card-mode.spec.ts (1)

14-14: LGTM! More robust test approach

The change from checking SVG path to verifying visibility is a better testing practice as it:

• Focuses on user-visible behavior rather than implementation details
• Makes the test more resilient to SVG path changes
• Better aligns with component's functional requirements

[github-actions]

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide