Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): [input] cancel bacground style of input count in textarea #2715

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

wNing50
Copy link
Contributor

@wNing50 wNing50 commented Dec 30, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

image

Issue Number: #2687

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

在'type="textarea"'且使用‘’maxlength‘’,"show-word-limit" 时,计数的样式为“background:#fff”,应该跟随其父元素。

Summary by CodeRabbit

  • Style
    • Updated textarea count styling by removing background color
    • Maintained existing textarea component styling and behavior

Copy link

coderabbitai bot commented Dec 30, 2024

Walkthrough

The pull request involves a modification to the LESS stylesheet for a textarea component. Specifically, the background property has been removed from the .@{input-prefix-cls}__count class. This change impacts the visual styling of the textarea's count display, potentially altering its appearance while maintaining the existing structure and state-related styles of the component.

Changes

File Change Summary
packages/theme/src/textarea/index.less Removed background: var(--tv-Textarea-bg-color); from .@{input-prefix-cls}__count class

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

🐰 A Textarea's Subtle Dance

Background fades, a style's soft glance
Count display stripped of its hue
A minimalist's gentle breakthrough
Styling whispers, clean and light
A rabbit's touch makes styling bright! 🎨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0fb1f3 and 0301936.

📒 Files selected for processing (1)
  • packages/theme/src/textarea/index.less (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/theme/src/textarea/index.less

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Dec 30, 2024
Copy link

Walkthrough

This pull request addresses a bug in the <tiny-input> component when used with type="textarea", maxlength, and show-word-limit. The background style of the input count is removed to ensure it follows its parent element's styling.

Changes

File Summary
packages/theme/src/textarea/index.less Removed the background style from the input count to ensure it inherits the parent element's background.

@zzcr zzcr merged commit a39c4bd into opentiny:dev Jan 2, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants