sync release-3.20.0 to dev #2716
Conversation
* feat: add saas-common runtime * feat: add saas-common runtime
…nd add base-select component (#2705) * fix(runtime): fix the problem of simple-runtime relying on echarts, and add base-select component * fix(runtime): fix the problem of simple-runtime relying on echarts, and add base-select component * feat: update runtime version
WalkthroughThis pull request encompasses modifications across multiple files in the OpenTiny Vue project. The changes primarily involve updating component build configurations, package versions, and styling. Key updates include modifying the Changes
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (9)packages/theme/src/form-item/index.less (1)
Adding Please verify the fix resolves any icon shrinking issues across:
Run this script to find test files that might help with verification: ✅ Verification successfulLet me check the test files to verify if there are any existing issues or if the change is properly tested. Let me check the actual form item styling to verify the flex-shrink property's context. The flex-shrink fix is properly implemented and verified After reviewing the code context, I can confirm that:
The implementation is correct and well-tested across:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Find relevant test files for form validation icon styling
# Look for form item test files and examples
fd -e vue -e spec -e test "form-item|form.*validation"
Length of output: 438 Script: #!/bin/bash
# Check the content of form validation test files to understand the test coverage
cat examples/sites/demos/pc/app/form/form-validation.vue examples/sites/demos/mobile-first/app/form/form-validation.vue
Length of output: 6903 Script: #!/bin/bash
# Check the form-item styles to understand the flex context
cat packages/theme/src/form-item/index.less
Length of output: 8791 internals/cli/src/commands/build/build-entry-app.ts (1)
✅ Verification successfulBased on the search results, I can verify that all the Huicharts components listed in the build-entry-app.ts file are properly defined and used consistently throughout the codebase. The findings show:
All Huicharts components are properly defined and consistently used across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Attempt to locate Huicharts imports in the codebase and confirm consistency.
rg 'Huicharts[A-Z]\w*' -A 5
Length of output: 66518 internals/cli/src/commands/build/build-runtime.ts (5)
✅ Verification successfulLet me search for more specific information about Vue and composition API usage in the codebase. Let me try a different search approach to find Vue and composition API usage. Let me search for specific dependencies and imports in the build configuration. Let me try a different search to find externals configuration and Vue dependencies. Let me check one more thing about the dependencies in the package configuration. Based on the gathered information, I can now provide a final response about the externals configuration. The externals configuration for The current configuration in
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Looks for references to @vue/composition-api and vue in tasks, verifying no unintended usage outside 'tiny-vue-saas-common'.
rg '@vue/composition-api|vue' -A 3
Length of output: 66384 Script: #!/bin/bash
# Search for Vue and composition API imports/usage
rg -A 3 "import.*@vue/composition-api|import.*vue" --type ts --type vue
Length of output: 101 Script: #!/bin/bash
# Search for Vue and composition API dependencies and imports
rg -A 3 "@vue/composition-api|vue" --type ts
Length of output: 119385 Script: #!/bin/bash
# Search for Vue and composition API related dependencies in build config
rg -A 3 "externals.*vue|externals.*composition-api" internals/cli/src/commands/build/
Length of output: 87 Script: #!/bin/bash
# Search for externals configuration and Vue dependencies in build files
rg -A 5 "externals|tiny-vue-saas-common|@vue/composition-api" internals/cli/src/commands/build/
Length of output: 3827 Script: #!/bin/bash
# Search for package dependencies and peer dependencies related to Vue
rg -A 5 '"dependencies"|"peerDependencies".*vue' packages/vue-saas-common/package.json packages/vue/package.json
Length of output: 908 packages/vue/src/fluent-editor/package.json (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request synchronizes changes from the release-3.20.0 branch to the dev branch. It includes updates to component names, build configurations, and package files, aiming to align the development branch with the latest release changes. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -119,6 +120,9 @@ async function batchBuildAll({ vueVersion, tasks, message, emptyOutDir, npmScope | |||
| external: (source, importer, isResolved) => { | |||
| if (isResolved || !importer) return false | |||
|
|
|||
| if (libPath === 'tiny-vue-saas-common') { | |||
| return ['@vue/composition-api', 'vue'].includes(source) | |||
There was a problem hiding this comment.
Ensure that adding libPath as a condition for external dependencies does not unintentionally exclude necessary modules for other libPath values.
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Release Notes
Version Updates
@opentiny/vue-themeto version 3.20.1@opentiny/vue-runtimeto version 3.20.4@opentiny/vue-fluent-editorto version 3.20.2Dependency Changes
@opentiny/fluent-editorto version 3.24.0Styling Improvements
Build Process
tiny-vue-saas-commonlibrary in build tasks