chore: sync 3.21.0 to dev #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: change docs content * docs: fix demo-list children miss width style
…sEdit is set true (#2770) * fix(grid): [grid] fix repeated trigger cell active when boardConfig.isEdit is set true * fix(grid): [grid] fix value to be set null when keyboard enter edit
* fix(theme-tool): add theme-tool.d.ts for tinyOldTheme vars * fix(theme): update version
* test: update @playwright/test to 1.49.x * test(grid): fix grid e2e test case * test(grid): fix grid e2e test case
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request involves a comprehensive set of changes across multiple files and components, primarily focusing on streamlining code, removing deprecated components, and updating dependencies. The modifications span GitHub Actions workflows, package configurations, test scripts, and component implementations. Key areas of change include removing the Rich Text Editor components, updating dependency management, and refactoring grid component interactions. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (66)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
WalkthroughThis pull request synchronizes the 3.21.0 version to the development branch. It includes various updates across multiple files, mainly focusing on test cases, package configurations, and some internal utilities. The changes aim to enhance the functionality and maintainability of the codebase. Changes
🪧 TipsFor further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me. |
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| // 如果是激活状态，退则出到下一行 | ||
| if (selected.row || actived.row) { | ||
| this.moveSelected({ | ||
| args: selected.row ? selected.args : actived.args, | ||
| isLeftArrow, | ||
| isUpArrow, | ||
| isRightArrow, | ||
| isDwArrow: true, | ||
| isDownArrow: true, |
There was a problem hiding this comment.
The variable isDwArrow has been renamed to isDownArrow. Ensure that this change is consistent across all related code to prevent potential errors.
| event | ||
| }) | ||
| } else if (treeConfig && highlightCurrentRow && currentRow) { | ||
| // 如果是树形表格当前行回车移动到子节点 | ||
| let childrens = currentRow[treeConfig.children] | ||
| if (childrens && childrens.length) { | ||
| const children = currentRow[treeConfig.children] |
There was a problem hiding this comment.
The variable childrens has been renamed to children. Ensure that this change is consistent across all related code to prevent potential errors.
kagol
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Based on the comprehensive summary, here are the concise release notes:
New Features
Bug Fixes
Documentation
Chores