fix(tooltip): remove :has selector on popper__arrow

[shenjunjian]

PR

:has选择器在低版本浏览器上不支持。此处has并不是必须的，可以移除

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Chores

  • Updated package version for @opentiny/vue-theme from 3.21.1 to 3.21.2

• Style

  • Simplified CSS selectors for popover and tooltip components to improve browser compatibility
  • Retained existing styling rules for arrow positioning and appearance

[coderabbitai]

Walkthrough

This pull request involves two primary changes: a version increment for the @opentiny/vue-theme package and modifications to CSS selectors in the reset.less file. The version in package.json has been updated from 3.21.1 to 3.21.2. In the reset.less file, CSS selectors for popover and tooltip components have been simplified by removing the :has() pseudo-class, which improves browser compatibility while maintaining the existing styling rules.

Changes

File	Change Summary
packages/theme/package.json	Version updated from 3.21.1 to 3.21.2
packages/theme/src/base/reset.less	Simplified CSS selectors for .tiny-popconfirm-popover, .tiny-popper, and .tiny-tooltip__popper by removing :has(.popper__arrow)

Possibly related PRs

• fix(form): [form] fix form tooltip class name #2154: Version update for @opentiny/vue-form-item package
• fix(theme): Fixed an issue where some global styles become invalid when a theme is switched using an alias. #2395: Version update for @opentiny/vue-theme package
• fix(theme-tool): add theme-tool.d.ts for tinyOldTheme vars #2786: Previous version update for @opentiny/vue-theme package

Suggested labels

bug

Suggested reviewers

• zzcr

Poem

🐰 A rabbit's tale of code so neat,
Selectors trimmed, now more discreet
Version bumped with gentle care
Browser support beyond compare
Tiny changes, big delight! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d1fbeb and 5045487.

📒 Files selected for processing (2)

• packages/theme/package.json (2 hunks)
• packages/theme/src/base/reset.less (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/theme/package.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR Unit Test

🔇 Additional comments (2)

packages/theme/src/base/reset.less (2)

200-202: Good improvement for browser compatibility!

Removing the :has selector is a positive change as it improves compatibility with older browsers while maintaining the same visual styling.

---

Line range hint 200-246: Verify the impact on elements without arrows.

The removal of :has(.popper__arrow) means these styles will now apply to all instances of these components, regardless of whether they have an arrow. Please verify that this doesn't cause any styling issues for cases where arrows aren't present.

✅ Verification successful

The removal of :has(.popper__arrow) is safe as arrow visibility is properly handled through component props

The codebase shows that arrow visibility is managed through explicit props and classes (e.g. arrowVisible, no-arrow), making the :has() selector unnecessary. The change appears to be a refactor from border-based arrows to div-based arrows, which is an implementation detail that doesn't affect the arrow visibility logic.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for instances where these components might be used without arrows
rg -l "tiny-(popconfirm-popover|popper|tooltip__popper)" --type vue | while read -r file; do
  echo "=== $file ==="
  # Look for usage without popper__arrow
  rg "tiny-(popconfirm-popover|popper|tooltip__popper)" -A 5 -B 5 "$file"
done

Length of output: 112

---

Script:

#!/bin/bash
# Search for component usages without file type restriction
echo "=== Searching component usages ==="
rg "tiny-(popconfirm-popover|popper|tooltip__popper)" -g "*.{vue,js,jsx,ts,tsx}" -A 5 -B 5

echo -e "\n=== Searching component definitions ==="
rg "export.*(?:Popconfirm|Popper|Tooltip)" -g "*.{vue,js,jsx,ts,tsx}"

echo -e "\n=== Checking for arrow-related configurations ==="
rg "arrow|hideArrow|showArrow" -g "*.{vue,js,jsx,ts,tsx}" --type-add "vue:*.vue"

Length of output: 66554

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request removes the :has selector from the .popper__arrow elements in the tooltip component. The :has selector is not supported in lower versions of browsers and is not necessary for the functionality, so it has been removed to improve compatibility.

Changes

File	Summary
packages/theme/src/base/reset.less	Removed the :has selector from .tiny-popconfirm-popover, .tiny-popper, and .tiny-tooltip__popper classes to ensure compatibility with older browsers.

[github-actions]

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide