Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.8.1 #270

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Release 4.8.1 #270

merged 6 commits into from
Jan 3, 2024

Conversation

superchilled
Copy link
Contributor

Description

This PR follows on from #269 to provide more idiomatic usage of options hash for the Archives#create method. Specifically it:

  • Changes multi_archive_tag and stream_mode in the valid_opts array defined in Archives#create to snake_case from camelCase
  • Adds an ivar and attr_accessor for stream_mode in the Archive class
  • Adds a test for creating an archive with a specific stream_mode

Motivation and Context

#269 fixed a bug whereby the mutliArchiveTag and streamMode properties weren't being passed to the API endpoint. This PR makes the setting of those properties via the Archives#create method more idiomatic.

How Has This Been Tested?

Unit tests added and//or ammended to test the functionality.

Example Output or Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled merged commit 6632bb6 into main Jan 3, 2024
13 checks passed
@superchilled superchilled deleted the release-4.8.1 branch January 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant