Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onCreate callback to WebFluxSpanDecorator #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NHebrard
Copy link
Contributor

@NHebrard NHebrard commented Jan 4, 2021

Hello!

With this PR, WebFluxSpanDecorator will be extended with an onCreate() callback called right after the span creation.
Cf this issue: #140

Thanks, @geoand.

@geoand
Copy link
Collaborator

geoand commented Jan 4, 2021

@csabakos wanna take a look as well?

@csabakos
Copy link
Contributor

csabakos commented Jan 4, 2021

@csabakos wanna take a look as well?

The change LGTM but it would be good to understand a bit more about the use case to be able to say whether the change is really necessary or not. For example, why isn't the baggage getting extracted from the incoming HTTP headers or the parent span?

@kkrawczy
Copy link

@csabakos
The use case would be to add to the baggage custom items that are not present in the incoming HTTP headers.
WebFluxSpanDecorator sounds like a good component that could do it, but there is one problem.
During span activation, we put baggage values into MDC, so if WebFluxSpanDecorator operates after activation we miss the values that we want to inject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants