Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename examples to testbed. #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosalberto
Copy link
Contributor

Renamed examples to testbed, along the namespace name, to align to opentracing/opentracing-java#185

@MikeGoldsmith
Copy link
Member

Was this really necessary? I understand the need to get the core API to match the Java implementation as close as possible but I think this is superfluous, with Examples being a more accurate description of what is there.

@carlosalberto
Copy link
Contributor Author

@MikeGoldsmith It was mentioned in the past (in the Java repo) that the examples name was confusing as some of the scenarios are kinda exotic, and also because the purpose of these so-called examples was more to test out the API (along with changes and experimental features), more than being actual examples (and thus, confusing for newcomers).

Other repos do have actual examples, so we may want to add a few of them ;)

@cwe1ss
Copy link
Member

cwe1ss commented Apr 26, 2018

Hmm. We had to change the examples/testbed code anyway because of async/await so maybe our code is closer to being actual "examples" than in Java?!

I'm ok with both so feel free to merge/not merge as you like!

@cwe1ss
Copy link
Member

cwe1ss commented May 14, 2018

@carlosalberto @MikeGoldsmith how do you want to proceed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants