-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes #5
Misc changes #5
Conversation
james-callahan
commented
Aug 9, 2018
•
edited
Loading
edited
- Remove trailing whitespace
- Rename test/ to spec/ to follow busted convention
- Have :log_kv take an optional timestamp
- Add span:each_baggage_item()
d3f8811
to
5fc9b93
Compare
Most of those changes look good, but the other OT APIs don't have functions to lookup the tags and logs ... is there any reason we'd need them for Lua? |
It seems other languages have flirted with a See opentracing/specification#12 for |
I see the discussion for tag accessors, but I checked the Go and Java APIs and don't see that any methods were ever added to the interface for them. I'm fine with a function to iterate over the baggage -- that's pretty standard. |
5fc9b93
to
eff04b9
Compare
Rebased to have commits you're not sure about at the end (that way you can merge just the first commits if you want) |
I'm not sure how to do a partial merge like that. Could you just remove the get_tag, each_tag, and each_log functions? The other changes look good. |
eff04b9
to
626d186
Compare
Done. once merged I'll send another PR for those bits. |