fix: fixes the return type for withBaggageItems. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should consider be a breaking change, release it as v1.0.1 broke our application. If this project does not use Semantic Version, I'll need to lock this project at a specific version. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://github.com/jcchavezs/zipkin-php-opentracing/pull/47/files/786ec41106b5905cfa7322fb54138c3289c1dce4#diff-97fcfff133419a8975edbc55468b44e719498b39a9a1f12b3f45ee7002d901e2
Note: This kind of errors are the ones which we should have avoided by try the implementation before doing the release.