-
Notifications
You must be signed in to change notification settings - Fork 161
Testbed import #80
Testbed import #80
Conversation
README.rst
Outdated
^^^^^^^^^^^^^ | ||
|
||
A testbed suite designed to test API changes and experimental features is included under the `testbed` directory. For more information, see the `Testbed README <testbed/README.rst>`_. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why we're using .rst
for readme... seems like the only OT repo that does that :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very common in Python projects (or at least it was) using .rst
instead of Markdown. Some examples with widely used libraries:
- https://github.com/pallets/flask/blob/master/README.rst
- https://github.com/django/django/blob/master/README.rst
I don't have strong opinions on that, since what is important to me is the content of the README and keeping it consistent across other OT repos is a good idea.
setup.py
Outdated
], | ||
'testbed': [ | ||
'six>=1.10.0,<2.0', | ||
'futures', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under impression futures is not available in py3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it should not be installed for py3, but since the stdlib takes precedence in modules resolution, it should not be harmful / wrong in our testbed
. Conditional requires are available as follow:
setup(
...
extras_require={
':python_version == "2.7"': ['futures']
}
)
as described in the futures
package
We don't list the actual test list anymore, as we simply load any of them that starts with the test_ prefix.
testbed/README.rst was changed to testbed/README.md
Thanks for the feedback @yurishkuro and @palazzem
Let me know ;) |
Going to merge as we did for the Feel free to open an issue/PR on any change regarding the |
Sure thing, we can iterate over the |
Initial import of the testbed used in other languages.
Summary:
testbed
directory where the tests live, with extra dependencies insetup.py
(not affecting the main package, of course).asyncio
,tornado
,threading
andgevent
, as well as basic implementation ofScopeManager
for each of them.testbed/__main__.py
) checks the Python version, and disables the ones forasyncio
if running under Python 2 (otherwise, doingpy.test testbed/
runs all the tests). This also can be done throughmake testbed
.Ideally I'd like to have this merged (and adjusted if/as needed), prior to do the RC 2 ;)
@yurishkuro @palazzem @tedsuo