Add experimental support for GTFS Fares V2 #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
leonardehrenfried
force-pushed
the
fares-v2
branch
3 times, most recently
from
11064cc
to
1910d1d
Compare
hannesj
reviewed
Aug 22, 2022
hannesj
reviewed
Aug 22, 2022
src/ext/java/org/opentripplanner/ext/fares/impl/GtfsFaresV2Service.java
Outdated
Show resolved
Hide resolved
hannesj
reviewed
Aug 22, 2022
leonardehrenfried
force-pushed
the
fares-v2
branch
from
1910d1d
to
2502694
Compare
hannesj
reviewed
Aug 24, 2022
hannesj
previously approved these changes
Aug 24, 2022
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
hannesj
approved these changes
Aug 25, 2022
|
@vesameskanen Do you think you can provide a review for this PR? If not let us know and I will ask someone else. |
|
Yes, working on it right now. I am going to test the feature by remodeling HSL fares into V2 format, in order to understand better how the setup works in real life. This final test should be ready by tomorrow. |
vesameskanen
approved these changes
Sep 1, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 1, 2022
t2gran
pushed a commit
that referenced
this pull request
Sep 1, 2022
mbsalvatore
pushed a commit
to camsys/OpenTripPlanner
that referenced
this pull request
Oct 18, 2023
Add experimental support for GTFS Fares V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for recently added GTFS Fares V2.
The full (unmerged) spec is very large but this PR only implements the part that is in the mainline GTFS repo plus a few additions. As of this PR, the list of supported features is:
There are more features that I want to implement, namely fare_transfer_rules, but they will come in a later PR.
TODO before merge
Issue
n/a
Unit tests
Lots of tests added.
Documentation
added