-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GBFS support to v2.3 #4809
Conversation
case CAR -> CAR; | ||
case MOPED -> MOPED; | ||
case SCOOTER -> SCOOTER; | ||
case SCOOTER_STANDING -> SCOOTER_STANDING; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if we need this distinction. We can discuss briefly in the meeting.
It's kinda nice to see that the Java compiler now helps to figure out where all the places are you need to change the code when adding an enum value. |
8cd82aa
to
f830edb
Compare
Codecov ReportBase: 62.14% // Head: 62.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4809 +/- ##
=============================================
- Coverage 62.14% 62.13% -0.01%
- Complexity 13000 13003 +3
=============================================
Files 1650 1650
Lines 66064 66092 +28
Branches 7184 7183 -1
=============================================
+ Hits 41055 41068 +13
- Misses 22669 22686 +17
+ Partials 2340 2338 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked fast through this and @testower also approved, so this is good to go.
Summary
We might want to include new features from GBFS v2.3, such as the return constraints later on.
Issue
Currently we are unable to parse new form factors and propulsion types introduced in GBFS v2.3