Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GBFS support to v2.3 #4809

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Feb 8, 2023

Summary

We might want to include new features from GBFS v2.3, such as the return constraints later on.

Issue

Currently we are unable to parse new form factors and propulsion types introduced in GBFS v2.3

@hannesj hannesj added technical debt Entur test This is currently being tested at Entur Vehicle rental labels Feb 8, 2023
@hannesj hannesj added this to the 2.3 milestone Feb 8, 2023
@hannesj hannesj requested a review from a team as a code owner February 8, 2023 13:48
case CAR -> CAR;
case MOPED -> MOPED;
case SCOOTER -> SCOOTER;
case SCOOTER_STANDING -> SCOOTER_STANDING;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if we need this distinction. We can discuss briefly in the meeting.

@leonardehrenfried
Copy link
Member

It's kinda nice to see that the Java compiler now helps to figure out where all the places are you need to change the code when adding an enum value.

testower
testower previously approved these changes Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 62.14% // Head: 62.13% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f830edb) compared to base (b0b5f36).
Patch coverage: 36.11% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4809      +/-   ##
=============================================
- Coverage      62.14%   62.13%   -0.01%     
- Complexity     13000    13003       +3     
=============================================
  Files           1650     1650              
  Lines          66064    66092      +28     
  Branches        7184     7183       -1     
=============================================
+ Hits           41055    41068      +13     
- Misses         22669    22686      +17     
+ Partials        2340     2338       -2     
Impacted Files Coverage Δ
...anner/ext/legacygraphqlapi/LegacyGraphQLUtils.java 26.86% <0.00%> (-1.26%) ⬇️
...tafetchers/LegacyGraphQLRentalVehicleTypeImpl.java 13.63% <0.00%> (-6.37%) ⬇️
...raphqlapi/generated/LegacyGraphQLDataFetchers.java 0.00% <ø> (ø)
...ter/vehicle_rental/datasources/GbfsFeedLoader.java 61.03% <ø> (ø)
...ental/datasources/GbfsFreeVehicleStatusMapper.java 0.00% <ø> (ø)
...e_rental/datasources/GbfsGeofencingZoneMapper.java 68.00% <ø> (ø)
...ntal/datasources/GbfsStationInformationMapper.java 61.01% <ø> (ø)
...le_rental/datasources/GbfsStationStatusMapper.java 57.44% <ø> (ø)
...ental/datasources/GbfsSystemInformationMapper.java 92.30% <ø> (ø)
...ental/datasources/GbfsVehicleRentalDataSource.java 70.58% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hannesj hannesj requested review from testower and leonardehrenfried and removed request for testower February 9, 2023 19:28
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked fast through this and @testower also approved, so this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entur test This is currently being tested at Entur technical debt Vehicle rental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants