-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GTFS GraphQL API by default, remove the word "legacy" from its documentation #5202
Merged
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:remove-legacy
Jun 22, 2023
Merged
Enable GTFS GraphQL API by default, remove the word "legacy" from its documentation #5202
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:remove-legacy
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5202 +/- ##
=============================================
+ Coverage 65.42% 65.44% +0.01%
- Complexity 14477 14491 +14
=============================================
Files 1755 1754 -1
Lines 67987 68022 +35
Branches 7231 7238 +7
=============================================
+ Hits 44482 44515 +33
- Misses 21035 21042 +7
+ Partials 2470 2465 -5
☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
Enable GTFS GraphQL API by deafult, remove the word "legacy" from its documentation
Enable GTFS GraphQL API by default, remove the word "legacy" from its documentation
Jun 20, 2023
leonardehrenfried
requested review from
optionsome,
jtorin and
vpaturet
and removed request for
optionsome
June 20, 2023 08:44
jtorin
requested changes
Jun 21, 2023
Co-authored-by: Johan Torin <jtorin@users.noreply.github.com>
jtorin
approved these changes
Jun 21, 2023
vpaturet
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's finally happening! This removes the word legacy from the API that is now going to be known as GTFS GraphQL API in the documentation.
It also renames its feature switch to
GtfsGraphQlApi
and enables it by default.Issue
Relates to #4828