Make Transmodel GraphQl API an official OTP API #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
changed the title
t2gran
commented
Dec 13, 2023
src/ext/java/org/opentripplanner/ext/transmodelapi/mapping/PreferencesMapper.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5573 +/- ##
=============================================
- Coverage 67.35% 67.24% -0.12%
+ Complexity 16150 16084 -66
=============================================
Files 1857 1852 -5
Lines 71075 70970 -105
Branches 7402 7399 -3
=============================================
- Hits 47872 47722 -150
- Misses 20745 20782 +37
- Partials 2458 2466 +8 ☔ View full report in Codecov by Sentry. |
jtorin
requested changes
Dec 14, 2023
src/main/java/org/opentripplanner/apis/transmodel/model/framework/PenaltyForStreetModeType.java
Show resolved
Hide resolved
src/main/java/org/opentripplanner/framework/application/OTPFeature.java
Outdated
Show resolved
Hide resolved
|
Please resolve the conflicts |
leonardehrenfried
previously approved these changes
Dec 14, 2023
leonardehrenfried
changed the title
|
Please also resolve the conflicts. |
leonardehrenfried
changed the title
Co-authored-by: Johan Torin <jtorin@users.noreply.github.com>
jtorin
requested changes
Dec 18, 2023
src/main/java/org/opentripplanner/framework/application/OTPFeature.java
Outdated
Show resolved
Hide resolved
|
Sorry, found two typos. |
t2gran
force-pushed
the
otp_move_transmodel_api
branch
from
c8bc65f
to
13d9717
Compare
Co-authored-by: Johan Torin <jtorin@users.noreply.github.com>
jtorin
approved these changes
Dec 18, 2023
leonardehrenfried
approved these changes
Dec 18, 2023
t2gran
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move Transmodel API out of the Sandbox and make it on by default.
Issue
🟥 No
Unit tests
🟥 No
Documentation
✅ Doc is updated. We probably need to write better doc on the transmodel API - that is not included here. I have only updated the doc so it should be correct.
Changelog
✅
Bumping the serialization version id
🟥 Not needed.