-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move REST API into sandbox #5580
Move REST API into sandbox #5580
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5580 +/- ##
=============================================
- Coverage 67.46% 67.46% -0.01%
+ Complexity 16197 16195 -2
=============================================
Files 1862 1862
Lines 71206 71222 +16
Branches 7405 7407 +2
=============================================
+ Hits 48041 48049 +8
- Misses 20674 20680 +6
- Partials 2491 2493 +2 ☔ View full report in Codecov by Sentry. |
e8b6e2f
to
89dbe0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a few package suggestions. The main principle is to organise packages in a logical order without cyclic dependencies. So, to place something in the right package you can look at the usage - where is it used and what does it use. But, currently it is a mess - the bigest problem is that things are organized by type, not by feature. For example all classes involved in paging should be under the top level package o.o.paging
, then sub-domain (itinerary-filter and token-generation), then type: model, service, support, mapping and so on. But, I don´t want some code to follow one way and other code to follow another - so at some point we will try to clean up everything (at least move critical mass 80% of the code).
src/main/java/org/opentripplanner/apis/common/json/FeedScopedIdDeserializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/common/json/FeedScopedIdKeyDeserializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/common/json/FeedScopedIdSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/common/json/JSONObjectMapperProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/common/json/GraphQLResponseSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/common/SemanticHash.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/framework/application/OTPFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/inspector/vector/DebugClientAreaStopPropertyMapper.java
Outdated
Show resolved
Hide resolved
8be001d
to
8768380
Compare
Ah, sorry Thomas. I accidentally rebased and probably wiped your review state. |
src/ext/java/org/opentripplanner/ext/restapi/model/error/PlannerError.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/plan/RoutingErrorType.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/api/mapping/FareMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/api/model/ApiApiTravelOptionsMakerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/api/model/ApiWalkStepTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/api/mapping/EnumMapperTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/error/PathNotFoundException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/error/PathNotFoundException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/gtfs/mapping/StreetNoteMapper.java
Outdated
Show resolved
Hide resolved
…ception.java Co-authored-by: Thomas Gran <t2gran@gmail.com>
…ception.java Co-authored-by: Thomas Gran <t2gran@gmail.com>
The files in src/ext/java/org/opentripplanner/ext/restapi/model/serverinfo should not be moved, they show up in the review without any changes. |
I've moved them back into the main code. |
Summary
This moves the REST API classes into a sandbox folder and adds a feature switch
LegacyRestApi
for them. For now this switch will be on. As soon as the new debug UI is ready for prime time, I plan to make it default to off.Then I suggest we have one more release with the API in a sandbox and remove it afterwards.
Issue
#4828
Documentation
The question is if we want to have Sandbox documentation for this feature. I would say no, since that would actually improve the REST API docs, which we don't want.