Pass-through should override transit-group-priority #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
changed the title
t2gran
commented
Jan 23, 2024
| @@ -28,7 +29,7 @@ | |||
| import org.opentripplanner.routing.api.request.framework.CostLinearFunction; | |||
| import org.opentripplanner.transit.model.site.StopLocation; | |||
|
|
|||
| public class RaptorRequestMapper { | |||
| public class RaptorRequestMapper<T extends RaptorTripSchedule> { | |||
There was a problem hiding this comment.
Adding the generic type here was necessary for adding tests. The DefaultAccessEgress -> AStar State😢
t2gran
force-pushed
the
fix_pass_through
branch
from
a0bb56e
to
65e47e6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5638 +/- ##
=============================================
- Coverage 67.50% 67.46% -0.05%
- Complexity 16285 16287 +2
=============================================
Files 1888 1889 +1
Lines 71547 71591 +44
Branches 7408 7414 +6
=============================================
- Hits 48301 48300 -1
- Misses 20747 20790 +43
- Partials 2499 2501 +2 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
approved these changes
Jan 30, 2024
jtorin
changed the title
Bartosz-Kruba
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pass-through and transit-group-priority uses the same Raptor feature and can not be use at the same time (for now - if needed we can fix this). In OTP now pass-through is disabled if transit-priority is enabled. This is a bit unfortunate since transit-priority is a more general thing that might be set up as a default configured feature, while pass-through is always specific to a request. So, it make more sense to turn it around and only allow transit-group-priority if no pass-through-stops exist in the request. This PR does exactly this.
Issue
🟥 This issue was reported internally at Entur, and no issue was created for it. The fix is very simple.
Unit tests
✅ Added a regression test and a smoke test on the mapping of pass-through-points
Documentation
🟥 No doc added
Changelog
🟥 This bug did not exist tín the previous version of OTP; Hence, there is no change.
Bumping the serialization version id
🟥 Not required