Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug information for stop/quay ID and stay-seated transfers #5962

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

Adds a little bit of extra information to the debug UI:

  • when you hover over a quay name, it will show the ID in a tooltip

Screenshot from 2024-07-10 12-31-36

  • stay-seated transfers will show up as an icon, which is also hoverable
    Screenshot from 2024-07-10 12-24-25

@leonardehrenfried leonardehrenfried added the OTP Debug UI The OTP bundled client label Jul 10, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner July 10, 2024 10:34
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.66%. Comparing base (05b9f38) to head (3ee1b46).
Report is 100 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5962      +/-   ##
=============================================
+ Coverage      69.53%   69.66%   +0.12%     
- Complexity     17113    17162      +49     
=============================================
  Files           1938     1942       +4     
  Lines          73773    73784      +11     
  Branches        7548     7550       +2     
=============================================
+ Hits           51298    51400     +102     
+ Misses         19838    19754      -84     
+ Partials        2637     2630       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried added this to the 2.6 (next release) milestone Jul 12, 2024
@leonardehrenfried leonardehrenfried requested review from optionsome and removed request for testower July 16, 2024 10:12
/>
);
} else {
return <></>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equivalent to returning null, which is a more common pattern.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to return null.

testower
testower previously approved these changes Jul 25, 2024
@leonardehrenfried leonardehrenfried merged commit 9858691 into opentripplanner:dev-2.x Jul 25, 2024
6 checks passed
t2gran pushed a commit that referenced this pull request Jul 25, 2024
@leonardehrenfried leonardehrenfried deleted the stop-id-debug branch July 25, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants