Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Error Renderer #834

Merged
merged 12 commits into from
Mar 30, 2023
Merged

New Error Renderer #834

merged 12 commits into from
Mar 30, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Mar 23, 2023 •
edited
Loading

Description:

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

This PR creates a new error renderer to for the first time ever render OTP2 errors! The old error renderer is not removed, as it is needed to render more "fundamental" errors (if the server is down, etc). This can be removed in future if we choose.
Screenshot 2023-03-23 at 4 35 22 PM

@miles-grant-ibigroup miles-grant-ibigroup force-pushed the new-mode-selector-error-renderer branch from a4523ad to 2f526be Compare March 23, 2023 20:45
@daniel-heppner-ibigroup daniel-heppner-ibigroup merged commit 9b24624 into new-mode-selector Mar 30, 2023
@daniel-heppner-ibigroup daniel-heppner-ibigroup deleted the new-mode-selector-error-renderer branch March 30, 2023 22:32
@daniel-heppner-ibigroup daniel-heppner-ibigroup restored the new-mode-selector-error-renderer branch March 30, 2023 22:46
daniel-heppner-ibigroup added a commit that referenced this pull request Mar 30, 2023
@daniel-heppner-ibigroup
Revert "Merge pull request #834 from opentripplanner/new-mode-selecto…
0246299 
…r-error-renderer"

This reverts commit 9b24624, reversing
changes made to b3d0b1c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup Awaiting requested review from daniel-heppner-ibigroup

Assignees

@daniel-heppner-ibigroup daniel-heppner-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-grant-ibigroup @daniel-heppner-ibigroup