Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Route Viewer header in mobile view #886

Merged
merged 2 commits into from
May 4, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented May 4, 2023

Description

This PR hides the redundant "Route Viewer" heading when in the mobile view.

Any thoughts on removing the 5px margin around the route filter box?

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?
Before After
Before image After image

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix thanks for doing this!

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! And I'd approve of taking out those 5px!

@binh-dam-ibigroup
Copy link
Collaborator Author

And I'd approve of taking out those 5px!

Both mobile and desktop?

@binh-dam-ibigroup binh-dam-ibigroup merged commit 75ec6fd into dev May 4, 2023
@binh-dam-ibigroup binh-dam-ibigroup deleted the remove-mobile-routeviewer-header branch May 4, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants