Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trip Details package #889

Merged
merged 2 commits into from
May 9, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:
Updates Trip Details to 4.0.0, which removes calories in favor of minutes walking.

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nervous about that core-utils lock file update but all seems to still be working

yarn.lock Outdated
@@ -2358,6 +2358,25 @@
lodash.isequal "^4.5.0"
qs "^6.9.1"

"@opentripplanner/core-utils@^8.2.1":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run yarn-deduplicate so it combines all the 8.x core-utils references?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah I dug through my notes and found yarn-deduplicate -s fewer yarn.lock

@amy-corson-ibigroup amy-corson-ibigroup merged commit ba00c62 into dev May 9, 2023
@amy-corson-ibigroup amy-corson-ibigroup deleted the update-trip-detail-dependencies branch May 9, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants