Route renderer a11y #904
Merged
Route renderer a11y #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if both are same.
miles-grant-ibigroup
approved these changes
May 24, 2023
| @@ -25,21 +25,26 @@ const Block = styled.span<{ color: string; isOnColoredBackground?: boolean }>` | |||
| `} | |||
| ` | |||
|
|
|||
| type RouteRendererProps = { | |||
| export type RouteRendererProps = { | |||
| fullRender?: boolean | |||
There was a problem hiding this comment.
Should we rename this to expandedRender or renderName?
There was a problem hiding this comment.
I dropped fullRender in acc109a. For immediate purposes the custom route renderer uses leg.onColoredBackground.
There was a problem hiding this comment.
I would be tempted to refactor that leg.onColoredBackground TBH.
miles-grant-ibigroup
requested changes
May 26, 2023
| <RouteRenderer | ||
| isOnColoredBackground={route.operator?.colorMode?.includes('gtfs')} | ||
| // All GTFS bg colors look strange with the top border | ||
| leg={generateFakeLegForRouteRenderer(route, true)} | ||
| style={{ | ||
| fontSize: routeNameFontSize(routeName) |
There was a problem hiding this comment.
The variable font size might be causing problems...
miles-grant-ibigroup
approved these changes
May 31, 2023
amy-corson-ibigroup
approved these changes
Jun 2, 2023
amy-corson-ibigroup
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improves visual accessibility by requesting custom route renderers to fully render route names if needed (especially in the pattern viewer and stop viewer).
PR Checklist: