Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n checks #906

Merged
merged 5 commits into from
Jun 26, 2023
Merged

I18n checks #906

merged 5 commits into from
Jun 26, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR adds CI checks for i18n messages (English and French) using the latest OTP-UI i18n scripts.

PR Checklist:

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • [na] Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working. Not sure why we're only testing English and French but I trust you

@binh-dam-ibigroup binh-dam-ibigroup merged commit c2aa1e3 into dev Jun 26, 2023
@binh-dam-ibigroup binh-dam-ibigroup deleted the i18n-checks branch June 26, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @miles-grant-ibigroup @amy-corson-ibigroup