Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render selected active itinerary when pasting URL #907

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

With this PR, the particular itinerary (ui_activeItinerary) being viewed when copying the current URL will also be shown when that URL is pasted in a new browser tab or when refreshing the page. This does not account for side effects from the OTP routing engine processing real-time data.

PR Checklist

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work well! Thanks so much

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time coming and long overdue! Thanks for some great changes.

@binh-dam-ibigroup binh-dam-ibigroup merged commit 100ad37 into dev Jun 1, 2023
@binh-dam-ibigroup binh-dam-ibigroup deleted the render-activeitin-from-url branch June 1, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants