Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule View Fix #914

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Schedule View Fix #914

merged 2 commits into from
Jun 7, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Jun 1, 2023

Description:
Thanks to the recently exposed CSS variables, the schedule viewer is now much more easily able to blend in to its surroundings!

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@binh-dam-ibigroup binh-dam-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Jun 6, 2023
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For info, to use this PR, the CSS needs to include a declaration such as:

:root {
  --main-base-color: #084c8d;
  --main-accent-color: #eee;
}

@miles-grant-ibigroup miles-grant-ibigroup merged commit ff6b88e into dev Jun 7, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the schedule-respect-styling branch June 7, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants