Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar Icon Cleanup #926

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Navbar Icon Cleanup #926

merged 2 commits into from
Jun 26, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:

  • Fix positioning of user log-in icon on mobile horizontal view
  • Standardize color and hover of navbar icons
  • Remove unnecessary code

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner while maintaining all existing functionality! Well done

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work

@amy-corson-ibigroup amy-corson-ibigroup merged commit ab207ff into dev Jun 26, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-navbar-icons branch June 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @miles-grant-ibigroup @daniel-heppner-ibigroup