Call Taker Time Picker Support External Updates #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Jun 30, 2023
|
Good catch thanks! Let me know how f28dc50 works for you |
| // Don't update if still typing | ||
| if (timeRef.current !== document.activeElement) { | ||
| setTypedTime( | ||
| safeFormat(dateTime, timeFormat, { |
There was a problem hiding this comment.
This needs to happen on initial render of the component (for situations such as pasting the URL into the browser), otherwise the "typed" time can be different from the status time as shown in the screenshot below.
There was a problem hiding this comment.
Good catch thanks! Let me add an initial load update
There was a problem hiding this comment.
Try 3ccd8d2
binh-dam-ibigroup
approved these changes
Jul 6, 2023
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and philip-cline and unassigned miles-grant-ibigroup and daniel-heppner-ibigroup
philip-cline
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There were some regressions that got introduced here. This PR resolves these with a second state for the text input, separate from the actual time input.
PR Checklist: