Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y button fixes #936

Merged
merged 2 commits into from
Jul 13, 2023
Merged

a11y button fixes #936

merged 2 commits into from
Jul 13, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Jun 30, 2023 •
edited
Loading

Description:

  • Adds the role "image" to mode SVGs, to ensure the aria-labels aren't overlooked by AT
  • Refactors "Copy Link" button aria-live to be more consistent across AT

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • [n/a] Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup requested changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some nitpicks

lib/components/narrative/trip-tools.js Show resolved Hide resolved
lib/components/narrative/trip-tools.js Show resolved Hide resolved
@amy-corson-ibigroup amy-corson-ibigroup removed their assignment Jul 6, 2023
@amy-corson-ibigroup amy-corson-ibigroup merged commit dfb2df0 into dev Jul 13, 2023
@amy-corson-ibigroup amy-corson-ibigroup deleted the misc-a11y-fixes branch July 31, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @miles-grant-ibigroup @daniel-heppner-ibigroup