Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small A11y Fixes #940

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Small A11y Fixes #940

merged 3 commits into from
Jul 19, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Jul 12, 2023 •
edited
Loading

Description:

  • Fixes accessibility issue where the mode selector fieldset was accompanied by an empty legend
  • Removes role="none" from Locale Selector list items

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • [n/a] Are appropriate Typescript types implemented?

@amy-corson-ibigroup amy-corson-ibigroup changed the title Fix: Add legend to mode selector fieldset Small A11y Fixes Jul 12, 2023
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@amy-corson-ibigroup amy-corson-ibigroup merged commit ab8f1b1 into dev Jul 19, 2023
@amy-corson-ibigroup amy-corson-ibigroup deleted the mode-selector-legend branch July 19, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amy-corson-ibigroup @binh-dam-ibigroup @miles-grant-ibigroup