UCP/ADDRESS: cleanup deprecated flags #10468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
reviewed
Jan 31, 2025
Comment on lines
+618
to
+619
| return ucp_address_unpack_byte_extended(ptr, UCP_ADDRESS_FLAG_MD_MASK, | ||
| addr_version, md_index); |
There was a problem hiding this comment.
there seems to be still a wire-compat issue - when old address arrives, we will initialize md_index as invalid
There was a problem hiding this comment.
do you mean then any of UCP_ADDRESS_FLAG_MD_ALLOC | UCP_ADDRESS_FLAG_MD_REG was packed by remote side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
cleanup deprecated flags in UCP address
Why?
to inclrease number of supported MDs