-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for bringing back popover=hint
and hover-triggering behavior
#617
Comments
Also-related issue with |
The Open UI Community Group just discussed
The full IRC log of that discussion<gregwhitworth> Topic: [Popup] Should we punt popup=hint to V2?<JonathanNeal> masonf: both `:open` and `:closed` were added. <tantek> 🎉 <JonathanNeal> una: could we use `:not(:open)`? <gregwhitworth> github: https://github.com//issues/617 <tantek> ^ that needs to be in an FAQ <JonathanNeal> masonf: they added `:closed` so that it can match things that _can_ have `:open`. <tantek> +1 <JonathanNeal> masonf: popup=hint is a great feature that I like and support. However, there are currently some issues. In #566 we decided to punt. There were accessibility issues. How do we hover? etc. I think we need to solve those features. However, without a way to connect the element with the element that triggered it, it makes accessibility bad. There are other issues. How do we trigger hints with keyboards? <JonathanNeal> masonf: I think we should remove support for popup=hint for now, and resolve it later when those issues are resolved. <JonathanNeal> masonf: it pains me to propose this <JonathanNeal> gregwhitworth: are these issues enumerated somewhere or in this issue? <JonathanNeal> masonf: yes, the issues are #526 and #530. <JonathanNeal> gregwhitworth: I have no strong opposition to this. Us having a v2 fast follow seems good. I would prefer to get it right. I’m supportive to bump it to v2. <masonf> q? <JonathanNeal> bkardell: I feel like we’re going to have similar issues adjacent to this where we introduce a new power that makes it really easy to do something that isn’t _quite_ the thing that you should be doing. We’ve held back on pushing the tabs stuff for a similar concern. I’m wondering; should we think about this somehow as a general problem? <JonathanNeal> bkardell: And based on discussing that general problem, have something to point to in the future, so that we can decide if we want to hold everything up until a problem is solved, or if we can release something knowing we will add more as we solve it. <scotto_> q+ <JonathanNeal> bkardell_: I don’t know if it is actually worse to ship it (popup=hint?) than to not, as you mentioned in the issue. <gregwhitworth> ack scotto_ <JonathanNeal> gregwhitworth: if you want to create a new issue to resolve this, we can look at it. <JonathanNeal> scotto_: a good line to differentiate this from tabs is that we can skip this and still ship something. <masonf> q+ <gregwhitworth> q+ <JonathanNeal> bkardell_: Yea. It’s definitely not the same. We stopped the custom element work because it made it really easy to use tabs and it could be the wrong way and that would be worse than having nothing. I think we’ll have this problem again at different levels. <JonathanNeal> scotto_: there’s always going to be a risk to do things the wrong way. we already have times we talk about it and its not accessible. I think the same thing could happen with tabs as well. Yea, people could use it the wrong way, but there would be guidance on how to do it the right way. <gregwhitworth> ack gregwhitworth <JonathanNeal> scotto_: back to the popup=hint proposal, I think this (punting popup=hint) is probably the best thing to do. <gregwhitworth> q+ <bkardell_> q+ <JonathanNeal> scotto_: I don’t know what punting this means, but if we can solve the blockers then I think we’d solve for the whole feature. <JonathanNeal> masonf: I would rather develop the right pattern for the tooltip first and then provide the tooltip element. <gregwhitworth> ack masonf <JonathanNeal> masonf: I definitely see the point that it’s possible somebody wants to use a tooltip and use popup=auto and it will be bad. there are already these kinds of problems. however, this will provide something that improves the situation and has features to improve incrementally. <JonathanNeal> gregwhitworth: I am in agreement with masonf that we should still provide the API itself, and the accessibility benefit will be that unlock one thing as we fast follow the improved version. We would introduce new elements that improve over time that do the right thing. I want to +1 delaying it, and fast following with whatever the hint definitions look like. <JonathanNeal> gregwhitworth: one thing I also wanted to raise is that in a lot of our companies projects; I don’t see us concretely have a plan to document our features. I’m curious, as Open-UI, would it be worth it for us to pick that up as well; like getting it added to MDN, etc. Just an idea. <masonf> Proposed resolution: remove support for `popup=hint` for now. Continue work, and add support later when blocking issues are resolved. <gregwhitworth> ack gregwhitworth <gregwhitworth> ack bkardell_ <JonathanNeal> bkardell_: I don’t specifically disagree with the decision. When it comes to something like this — do it and fast follow — in the case of popup: it is not exactly a primitive, but is not high-level either. it is something we’ll build on. what does it mean in real world terms to take a little bit longer to get popup=hint too. I was on the "ship it and learn a thing" for ShadowDOM, but in retrospect, I would have delayed it a <JonathanNeal> little more. <JonathanNeal> masonf: the counterpoint is that, if it had not shipped, we might not have web components today. <JonathanNeal> gregwhitworth: there can be business counterpoints, too. I don’t necessarily disagree with bkardell_’s statement, but all the ideas are very speculative until they can ship. <masonf> q+ <gregwhitworth> q+ <JonathanNeal> bkardell_: Currently, we have a prototype of this in Chromium. I don’t think we have any signals from Mozilla or WebKit. I don’t recall where we stand on the HTML PR for this. We can do whatever we want in the prototype and specification and the group who can try that. But if we took another month to get popup=hint right, could we positively impact the timeline? <gregwhitworth> ack masonf <JonathanNeal> masonf: one thing to remember is that popup=auto is a prerequisite for selectmenu, so the risk of holding this up is that we also hold up other features that build upon it. <JonathanNeal> masonf: I think it’s important to note: I think popup=hint is kind of its own thing. I think it’s a separable piece. I am confident we will eventually ship. As a separate piece, it can be shipped without changing the definition of the other two when they have shipped. <masonf> q+ <scotto_> big +1 to maron's point on the different types of popups <JonathanNeal> gregwhitworth: I want to get these PRs up to get meaningful reactions from WebKit. <masonf> The PR is open: https://github.com/whatwg/html/pull/8221 <bkardell_> I think you both make a strong argument, we will see if there is similar pushback from that level even... I think I am mostly asking questions based on some recent feels of my own more than anything <gregwhitworth> ack gregwhitworth <gregwhitworth> ack masonf <JonathanNeal> masonf: We have the PR (link above) and I would love some feedback. <masonf> Proposed resolution: remove support for `popup=hint` for now. Continue work, and add support later when blocking issues are resolved. <bkardell_> +q <JonathanNeal> +1 <bkardell_> ++q <bkardell_> q- <bkardell_> +1 <dandclark> +1 <masonf> RESOLVED: remove support for `popup=hint` for now. Continue work, and add support later when blocking issues are resolved. |
@josepharhar FYI, all of the |
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724
Per the [resolution](openui#617 (comment)), we have decided to punt `popup=hint` to the next version of this API. Accordingly, this PR removes `popup=hint` from the explainer.
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724
* Remove `popup=hint` from the explainer Per the [resolution](#617 (comment)), we have decided to punt `popup=hint` to the next version of this API. Accordingly, this PR removes `popup=hint` from the explainer. * Update TOC Co-authored-by: Mason Freed <masonf@chromium.org>
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1063078}
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1063078}
Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1063078}
Automatic update from web-platform-tests Remove popup=hint functionality Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1063078} -- wpt-commits: ad8a1a63482e80aed25a11cfca4d51fec774d380 wpt-pr: 36512
Automatic update from web-platform-tests Remove popup=hint functionality Per the [1] resolution, we're going to wait to spec/implement popup=hint, until we have a chance to resolve some of the blocking issues. This CL removes all functionality for popup=hint. I thought about adding another flag to gate this functionality, but the logic is already complex, and I didn't want to complicate it further. When the time comes to put it back, this CL can be reverted. [1] openui/open-ui#617 (comment) Bug: 1307772 Change-Id: Ic9122d7e362eb1c57ef7ea8b6e080a866fca5724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957293 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1063078} -- wpt-commits: ad8a1a63482e80aed25a11cfca4d51fec774d380 wpt-pr: 36512
That lack of While the hover stuff is interesting, the biggest loss is:
This is a large part of what makes the
Having to remake all of this functionality puts me back in the use space overlay business in a way that makes me question the benefits of moving to Alternatives while missingMy initial thought was to make it There's also a path by which |
Thanks for the comments and for looking deeply into Popover! Can you clarify one thing for me: you said this was the most important thing lost with
From that concern, it would seem that you are perhaps only concerned with making “tooltip” components? If so, could you not just use I do really want to see |
The reason that this lost is important is the part where "force-closed only other hint" points to a different popover class than the general popover class. One might say a transient popover class. That class does focus on "tooltip" components, but is necessary because there are "non-tooltip" components that deserve to be treated differently than Here we see a popover that has been opened by clicking a button that features options about the context bar. While this overlay is open, it should not trap tab, as forward/backward tab should take up out of the popover. However, while open, we do want users to be able to active "tooltip" popovers off of other buttons so that they know what to expect from interacting with those buttons and we want them to be able to do so without dismissing the current non-modal popover. The "place image" popover would need the "only other hint" or similar directive within its stack algorithm to achieve this, without continues user space popover management. So, while "hint" is what has outlined that we receive this capability to date, it is not specifically the interactions that might be implied by hint, but the additional class of overlays with a separate open/close algorithm that I'm wondering about the ability to persist in v1. As I attempted to clarify before, I think this could be mimicked by a combination of |
Cool, thank you very much for the detailed explanation. That is indeed exactly what To summarize those in one place:
In the meantime, I agree that if you want this behavior sooner, you'd have to use |
popup=hint
to V2?popover=hint
and hover-triggering behavior
There is now an explainer for |
On #526 (comment) we decided to hold off on specifying the "hover triggering" behaviors, and the
popuphovertarget
attribute. But without that feature, it has been suggested that it will be more difficult to makepopup=hint
accessible, due to the lack of context about the triggering element.Should we similarly punt the entire
popup=hint
part of this feature to V2, to be designed and shipped together withpopuphovertarget
?One downside is that folks trying to build "hinty" things with the pop-up API will probably turn to
popup=auto
instead, which will likely make a11y worse for a while.@scottaohara @aleventhal
The text was updated successfully, but these errors were encountered: