Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exclusive-accordion] Add sections on existing details issues and spicy sections #746

Merged
merged 2 commits into from
May 9, 2023

Conversation

dbaron
Copy link
Collaborator

@dbaron dbaron commented May 8, 2023

No description provided.

@dbaron dbaron requested a review from mfreed7 May 8, 2023 21:18
@dbaron
Copy link
Collaborator Author

dbaron commented May 8, 2023

See preview.

@dbaron dbaron marked this pull request as ready for review May 8, 2023 21:27
Copy link
Collaborator

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one rambling comment. Take it or leave it.

@dbaron dbaron merged commit 169786f into openui:main May 9, 2023
@bkardell
Copy link
Collaborator

bkardell commented May 9, 2023

Yeah, sorry I didn't have enough time to comment on this but spicy-sections is panel-set (or you might see panselset). I made a comment in the commit.

@dbaron
Copy link
Collaborator Author

dbaron commented May 9, 2023

Would it be appropriate to describe it as "panelset (previously known as spicy sections)"?

@bkardell
Copy link
Collaborator

probably close enough, yeah. @mirisuzanne wdyt?

@mirisuzanne
Copy link
Contributor

Yeah, that makes sense to me.

dbaron added a commit to dbaron/open-ui that referenced this pull request May 10, 2023
Merge the sections on panelset and spicy sections based on the
discussion starting at
openui#746 (comment)
dbaron added a commit that referenced this pull request May 15, 2023
…#748)

Merge the sections on panelset and spicy sections based on the
discussion starting at
#746 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants